fix the icc register missing definition #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: the icc_sre_el2 register belongs to gic icc registers, which GNU AS is not aware of so it needs to be replaced by its op0,op1,CRn,CRm,op2 encoding, but currently there is compiling error. We find this definition in armv8/inc/sysregs.h but with Uppercase How: needs to use in aarch64/inc/sysregs.h, and change here with Uppercase Signed-off-by: JianlongCao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: the icc_sre_el2 register belongs to gic icc registers, which GNU AS is not aware of so it needs to be replaced by its op0,op1,CRn,CRm,op2 encoding, but currently there is compiling error. We find this definition in armv8/inc/sysregs.h but with Uppercase How: needs to use in aarch64/inc/sysregs.h, and change here with Uppercase
Signed-off-by: JianlongCao [email protected]